Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster-scanner): Introduce support to external secrets accessKeySecret #1287

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

dark-vex
Copy link
Collaborator

@dark-vex dark-vex commented Aug 7, 2023

What this PR does / why we need it:

Introduce the possibility to use external secret for cluster scanner.
Currently it is possible to specify a global.sysdig.accessKeySecret for all the components besides the cluster scanner.

When using the external secret accessKeySecret the environment variable SYSDIG_ACCESS_KEY will look for the key access-key instead of sysdig_access_key, I did that in order to align with the other charts

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

Signed-off-by: Daniele De Lorenzi <[email protected]>
Signed-off-by: Daniele De Lorenzi <[email protected]>
Copy link
Contributor

@AlbertoBarba AlbertoBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dark-vex dark-vex merged commit d44e1f6 into master Sep 20, 2023
5 checks passed
@dark-vex dark-vex deleted the cluster-scanner-accessKeySecret-fix branch September 20, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants